Skip to content

expose execution context for validity::to_bool and remove validity mask from array vtable#7432

Merged
gatesn merged 12 commits intodevelopfrom
ji/all-around-cdtx
Apr 15, 2026
Merged

expose execution context for validity::to_bool and remove validity mask from array vtable#7432
gatesn merged 12 commits intodevelopfrom
ji/all-around-cdtx

Conversation

@joseph-isaacs
Copy link
Copy Markdown
Contributor

No description provided.

Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>

# Conflicts:
#	vortex-array/src/arrays/primitive/compute/cast.rs
@joseph-isaacs joseph-isaacs added the changelog/chore A trivial change label Apr 14, 2026
@joseph-isaacs joseph-isaacs marked this pull request as ready for review April 14, 2026 19:22
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Apr 14, 2026

Merging this PR will degrade performance by 23.28%

⚡ 10 improved benchmarks
❌ 16 regressed benchmarks
✅ 1127 untouched benchmarks
⏩ 1455 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation bench_many_codes_few_values[2048] 296.7 µs 369.8 µs -19.77%
Simulation bench_many_codes_few_values[1024] 293.8 µs 366.9 µs -19.93%
Simulation bench_sparse_coverage[0.01] 365.5 µs 438.7 µs -16.67%
Simulation bench_many_nulls[0.5] 326.6 µs 364.9 µs -10.49%
Simulation bench_many_codes_few_values[4096] 302.7 µs 375.8 µs -19.46%
Simulation bench_sparse_coverage[0.5] 292.7 µs 365.8 µs -19.99%
Simulation bench_many_nulls[0.9] 472.7 µs 540.3 µs -12.5%
Simulation bench_sparse_coverage[0.1] 293.9 µs 367 µs -19.92%
Simulation patched_take_10k_contiguous_not_patches 286.3 µs 227.9 µs +25.64%
Simulation patched_take_10k_dispersed 344 µs 285.6 µs +20.43%
Simulation patched_take_10k_contiguous_patches 286.1 µs 227.6 µs +25.71%
Simulation patched_take_10k_first_chunk_only 330.1 µs 271.6 µs +21.54%
Simulation take_10k_first_chunk_only 283.1 µs 225.6 µs +25.5%
Simulation take_10k_contiguous 269.8 µs 328.2 µs -17.78%
Simulation patched_take_10k_random 298.3 µs 239.8 µs +24.41%
Simulation take_10k_dispersed 297 µs 239.4 µs +24.05%
Simulation new_alp_prim_test_between[f32, 16384] 106.4 µs 121 µs -12.05%
Simulation take_10k_random 192.9 µs 251.5 µs -23.28%
Simulation new_alp_prim_test_between[f32, 32768] 156.1 µs 185.4 µs -15.82%
Simulation new_alp_prim_test_between[f64, 16384] 127.8 µs 157.8 µs -19.05%
... ... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.


Comparing ji/all-around-cdtx (63e5b21) with develop (9406303)

Open in CodSpeed

Footnotes

  1. 1455 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>

# Conflicts:
#	vortex-array/src/builders/listview.rs
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
@gatesn gatesn enabled auto-merge (squash) April 15, 2026 19:10
@gatesn gatesn removed the changelog/chore A trivial change label Apr 15, 2026
@gatesn gatesn merged commit 3188e24 into develop Apr 15, 2026
60 of 112 checks passed
@gatesn gatesn deleted the ji/all-around-cdtx branch April 15, 2026 19:19
@gatesn gatesn added changelog/chore A trivial change changelog/break A breaking API change and removed changelog/chore A trivial change labels Apr 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/break A breaking API change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants